Re: [Xen-devel] [PATCH v9 1/8] xen: introduce gnttab_max_frames and gnttab_max_maptrack_frames command line options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.14 at 18:58, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> Changes in v9:
> - fix coding style for comments;

Half way...

> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -40,16 +40,27 @@
>  #include <xsm/xsm.h>
>  #include <asm/flushtlb.h>
>  
> -#ifndef max_nr_grant_frames
> -unsigned int max_nr_grant_frames = DEFAULT_MAX_NR_GRANT_FRAMES;
> +/* 
> + * this option is deprecated, use gnttab_max_frames and
> + * gnttab_max_maptrack_frames instead
> + */

Quoting ./CODING_STYLE: "Multi-word comments should begin with
a capital letter and end with a full stop".

> @@ -2930,6 +2936,25 @@ static struct keyhandler 
> gnttab_usage_print_all_keyhandler = {
>  
>  static int __init gnttab_usage_init(void)
>  {
> +    BUILD_BUG_ON(DEFAULT_MAX_MAPTRACK_FRAMES < DEFAULT_MAX_NR_GRANT_FRAMES);

This would better be put near the place it matters, i.e.

> +
> +    if ( max_nr_grant_frames )
> +    {
> +        printk(XENLOG_WARNING
> +               "gnttab_max_nr_frames is deprecated, use gnttab_max_frames 
> instead\n");
> +        if ( !max_grant_frames )
> +            max_grant_frames = max_nr_grant_frames;

... here.

But these issues are minor and don't by themselves warrant a re-spin
(they could be fixed while committing).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel