Re: [Xen-devel] [PATCH ARM v8 2/4] mini-os: arm: interrupt controller

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-10-21 at 16:22 +0100, Julien Grall wrote:
> On 10/21/2014 04:16 PM, Ian Campbell wrote:
> > On Tue, 2014-10-21 at 15:26 +0100, Julien Grall wrote:
> >> Our implementation of ITARGETSR doesn't handle correctly read/write per
> >> byte. If the register is RO (such as for the SGIs and PPIs), our write
> >> ignore is checking that the guest is writing a word.
> > 
> > That's a bug.
> 
> Agree
> 
> >> Even though we need to fix it in Xen (I could send a patch for it). We
> >> need to keep this implementation if we want mini-os to run on Xen 4.4.x.
> > 
> > We should fix bugs, not workaround them in the guest.
> 
> Writing a 32 bits value into those registers is perfectly value and not
> a workaround.

If you would normally write 1 byte (which makes perfect sense for this
register) but can't because of a Xen bug then avoiding that by
read/modify/write of 4 bytes because of a Xen bug *is* a workaround.

> In this case, it would make mini-os working directly on Xen 4.4.

and how long should mini-os carry this hack for then?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel