Re: [Xen-devel] [RFC PATCH v2 11/12] xen: arm: implement XEN_SYSCTL_cpufreq_op

[Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>]

On Wed, Oct 22, 2014 at 1:24 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 22.10.14 at 12:09, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
>> On Wed, Oct 22, 2014 at 12:34 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>> On 22.10.14 at 10:46, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
>>>> On Fri, Oct 17, 2014 at 4:21 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>>>> On 16.10.14 at 13:27, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
>>>>>> --- a/xen/include/xen/cpufreq.h
>>>>>> +++ b/xen/include/xen/cpufreq.h
>>>>>> @@ -20,6 +20,7 @@
>>>>>>  #include <xen/spinlock.h>
>>>>>>  #include <xen/errno.h>
>>>>>>  #include <xen/cpumask.h>
>>>>>> +#include <public/sysctl.h>
>>>>>
>>>>> Please don't add new dependencies that aren't needed (not even
>>>>> on ARM).
>>>> I'll create a separate file hwdom-cpufreq.h and I'll use it.
>>>
>>> I don't follow - you just don't need the #include above; no need to
>>> create a new header.
>> The structure 'xen_sysctl_cpufreq_op_t' could not be defined in the
>> original file cpufreq.h
>> because all sysctl-related structures are defined in the
>> xen/include/public/sysctl.h.
>> And if this structure will be defined in the cpufreq.h than this file
>> should be included to the sysctl.h (and it is not an acceptable solution).
>
> No. It is sufficient for the structure to be forward declared when
> all you need is declaring a function argument as a pointer to it.
I'll try to do this.

> Jan
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel