Re: [Xen-devel] [PATCH 2/2] tools: Clear private variables from configure --with-opt

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH 2/2] tools: Clear private variables from configure 
--with-opt"):
> Configure will use variables from environment when substituting a
> private variable if the corresponding --with*-foo option is omited.
> This happens for seabios_path, ovmf_path and EXTRA_QEMUU_CONFIGURE_ARGS:
> 
> git clean -dfx
> env EXTRA_QEMUU_CONFIGURE_ARGS=XXXXXXXXXXXXXXXX ./configure
> grep XXXXXXXXXXXXXXXX config/Tools.mk
> CONFIG_QEMUU_EXTRA_ARGS:= XXXXXXXXXXXXXXXX
> 
> The reason is the empty "action-if-not-given" case. Fix the bug by
> clearing the variables in this case.

Why on earth is this a problem ?  My answer is `don't do that then'.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel