Re: [Xen-devel] [PATCH for-xen-4.5 v4 00/18] xen: Break multiboot (v1) dependency and add multiboot2 support

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/10/14 11:19, Jan Beulich wrote:
>>>> On 17.10.14 at 17:49, <daniel.kiper@xxxxxxxxxx> wrote:
>> What is your main concern here (beside that it is big patch series)?
> The size alone is not the reason. As already said, I'm not convinced
> that the approach you use is ultimately the right one (and Andrew
> seems to agree, at least to some degree). And then, looking at your
> track record, apart from some kexec (and even older tool stack)
> work there hasn't been much you've been doing earlier particularly
> with the kind of fragile initial boot code. Hence I think the only
> viable route for you to get MB2 code merged is to just add it
> _without_ largely re-writing all sorts of other code. Once that
> happened we can then go and see whether the consolidation you're
> thinking of is (a) the right approach and (b) you're the one to carry
> it out.
>
> Jan
>

To add to this a little.  I still can't see a reasonable justification
for the new "multiboot data" type.  I think it would be perfectly
reasonable keep the multiboot1/2 distinction up until the boot_info
stage, and cast the pointer based on multiboot magic.

This would vastly reduce the changes in the boot assembly.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel