[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] stubdom/Makefile should use QEMU_TRADITIONAL_LOC

On Fri, 24 Oct 2014, Wei Liu wrote:

On Thu, Oct 23, 2014 at 06:37:43PM +0100, M A Young wrote:
CONFIG_QEMU was replaced by QEMU_TRADITIONAL_LOC in several places but not
in stubdom/Makefile, and as a result building stubdom is likely to fail when
xen-setup-stubdom isn't found. This patch replaces CONFIG_QEMU with
QEMU_TRADITIONAL_LOC in stubdom/Makefile as well.

While I understand the rationale behind this change, I'm a bit confused
by the description. What does it mean by "is likely to fail"? Does it
mean it succeeds sometimes and fails sometimes?

What's your build setup? I'm wondering why this is not caught in

If OSSTest is setting CONFIG_QEMU explicitly then the build of stubdom will work, as will everything else as QEMU_TRADITIONAL_LOC is set to the value of CONFIG_QEMU (in Config.mk) if it exists. Nothing in the xen code sets CONFIG_QEMU so if it isn't set explicitly stubdom/Makefile sets QEMU_ROOT to . in stubdom/Makefile which isn't the right path for xen-setup-stubdom (unless something is copying it over).

        Michael Young

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.