Re: [Xen-devel] [PATCH v14 for-xen-4.5 00/21] x86/PMU: Xen PMU PV(H) support

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 10/27/2014 03:38 AM, Dietmar Hahn wrote:
> Hi Boris,
>
> Am Freitag 17 Oktober 2014, 17:17:48 schrieb Boris Ostrovsky:
> > Version 14 of PV(H) PMU patches.
> >
> > Changes in v14:
> >
> > * Moved struct xen_pmu_regs to pmu.h
> > * Moved CHECK_pmu_* to an earlier patch (when structures are first introduced)
> > * Added PMU_SAMPLE_REAL flag to indicate whether the sample was taken in real 
> > mode
> > * Simplified slightly setting rules for xenpmu_data flags
> > * Rewrote vpmu_force_context_switch() to again use continuations. (Returning 
> > EAGAIN
> >    to user would mean that VPMU mode may get into inconsistent state (across 
> > processors)
> >    and dealing with that is more compicated than I'd like).
> > * Fixed msraddr_to_bitpos() and converted it into an inline
> > * Replaced address range check in vmpu_do_interrupt() with guest_mode()
> > * No error returns from __initcall
> > * Rebased on top of recent VPMU changes
> > * Various cleanups
> I did some tests with the Intel part and all went fine, so
>
> Tested-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
Excellent, thanks!

> Btw. you use different names for the same structure in the linux kernel driver
> part "struct xen_arch_pmu" and in the xen part "struct xen_pmu_arch". This is a
> little bit confusing when searching through the code. So when possible ... ;-)
> Many thanks!
Linux driver had quite a few changes since I posted it last time (mostly 
due to requested API changes on Xen side) so the header files will need 
to be copied anew anyway. And structure names will be updated at that time.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel