Re: [Xen-devel] [PATCH OSSTEST v2 10/20] standalone: Introduce "HostGroups" for use in OSSTEST_CONFIG

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-10-29 at 16:22 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 10/20] standalone: Introduce 
> "HostGroups" for use in OSSTEST_CONFIG"):
> > This saves repeating identical HostProp and HostFlags for sets of identical
> > machines. e.g.
> 
> Thanks.
> 
> > -    # First, we use the config file's general properites as defaults
> > +    # First, set the prop group if any.
> > +    foreach my $k (keys %c) {
> > +   next unless $k =~ m/^HostGroup_([-a-z0-9]+)$/;
> > +   next unless $1 eq $name;
> 
> Am I being dim or could this loop be replaced with a single lookup of
> $c{"HostGroup_${name}"} ?

Uh, no, I think it was me who was being dim.

> Apart from that this looks fine to me.

Thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel