Re: [Xen-devel] [OPW PATCH] tools/xl: Call init function for libxl_bitmap

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Mon, 2014-10-20 at 16:23 +0100, Wei Liu wrote:
> On Sun, Oct 19, 2014 at 08:21:01PM +0530, Uma Sharma wrote:
> > This patch calls init function for libxl_bitmap in
> > main_cpupoolnumasplit() and vcpuset()
> > tools/libxl/xl_cmdimpl.c
> > IDL generated libxl types should be used only after calling the init
> > function even if the variable is simply being passed by reference as
> > an output parameter to a libxl function
> > 
> > Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c

> > @@ -4843,7 +4843,8 @@ static void vcpuset(uint32_t domid, const char* 
> > nr_vcpus, int check_host)
> >      char *endptr;
> >      unsigned int max_vcpus, i;
> >      libxl_bitmap cpumap;
> > -
> > +    
> > +    libxl_bitmap_init(&cpumap);
>
This is introducing some white space damaging, IMO.

In fact, it seems you are removing a black line, i.e., a line which was
*totally* empty, as it should be, with one which has _only_ 4 white
spaces.

That's kind of common while working on patches, I know, but it's not
what we want.

To avoid sending patches suffering from this issue, you certainly can
configure your editor to properly deal with the Xen coding style. What I
also find really useful is that, if looking at the patch with `git show'
or `stg show', the trailing white spaces are marked in red (yes, you
probably need to configure git for that, but, if you're lucky, that's
already the default for your dev environment).

> > @@ -7254,7 +7255,8 @@ int main_cpupoolnumasplit(int argc, char **argv)
> >      }
> >  
> >      ret = 0;
> > -
> > +    
> > +    libxl_bitmap_init(&cpumap);
>
Same here.

TBH, I'm a bit confused, and am not sure if this is the actual latest
version of this patch. If it's not, sorry for the noise.

Regards,
Dario

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel