Re: [Xen-devel] [RFC PATCH v2 09/11] time: Convert pvclock_read_wallclock() to use timespec64

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 30/10/14 11:15, pang.xunlei wrote:
> As part of addressing 2038 safety for in-kernel uses, this patch
> creates no functional change, converts pvclock_read_wallclock()
> to use timespec64 instead of timespec.

Acked-by: David Vrabel <david.vrabel@xxxxxxxxxx>

With one minor comment:

>  
>       /* get wallclock at system boot */
>       do {
>               version = wall_clock->version;
>               rmb();          /* fetch version before time */
> -             now.tv_sec  = wall_clock->sec;
> +             /* TODO: [2038 safety] wall_clock->sec uses time64_t */
> +             now.tv_sec  = (time64_t)wall_clock->sec;

The size of wall_clock->sec is fixed as part of the hypervisor ABI so
there's nothing TODO here (it would require extensions to the hypervisor
ABI and thus a new pvclock_read_wallclock64() call or similar).

David


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel