Re: [Xen-devel] [PATCH 2/6] vTPM: add HVM_PARAM_STUBDOM_VTPM parameter for HVM virtual machine

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 30 Oct 2014, Andrew Cooper wrote:
> On 30/10/14 12:05, Xu, Quan wrote:
> >
> >> -----Original Message-----
> >> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> >> Sent: Thursday, October 30, 2014 7:50 PM
> >> To: Xu, Quan; xen-devel@xxxxxxxxxxxxx
> >> Cc: keir@xxxxxxx; ian.campbell@xxxxxxxxxx; tim@xxxxxxx;
> >> ian.jackson@xxxxxxxxxxxxx; jbeulich@xxxxxxxx
> >> Subject: Re: [Xen-devel] [PATCH 2/6] vTPM: add
> >> HVM_PARAM_STUBDOM_VTPM parameter for HVM virtual machine
> >>
> >> On 30/10/14 07:38, Quan Xu wrote:
> >>> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> >> What is the purpose of this parameter?  A patch like this is currently
> >> unacceptable, especially as the libxl hunk indicates that the parameter 
> >> name
> >> does not match whatever information you are putting into it.
> >>
> > Thanks for your suggestion. 
> > This parameter tell the Qemu whether to register Qemu vTPM frontend in 
> > xen_hvm_init().
> > Qemu will get the parameter value by xc_get_hvm_param(). How can I change 
> > it?
> 
> This is surely something which should be a command line parameter to
> qemu, or perhaps for qemu to read out of xenstore.
> 
> An HVM param is entirely inappropriate for this purpose, in my opinion.

I agree that an HVM param for this might not the best way to do it, but I
can see why Quan did it that way as we already have a few key parameters
passed to QEMU that way.

A QEMU command line option, QMP command or xenstore key would be better.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel