Re: [Xen-devel] [PATCH] tools/hvmloader: link errno.h from xen internal

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.10.14 at 11:54, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 31/10/14 10:51, Jan Beulich wrote:
>>>>> On 31.10.14 at 11:04, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 31/10/14 02:18, Tiejun Chen wrote:
>>>> We will use some error numbers in hvmloader so here just link
>>>> this head file from xen.
>>>>
>>>> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
>>> We already use stdint, stdarg, stdarg and error (in xenbus.c) from the
>>> build environment.
>>>
>>> All of these are safe from an embedded point of view, which is
>>> essentially what we are doing with hvmloader.
>>>
>>> I highly suggest we just go with the environments error.h and be done
>>> with it.  C99 is very nice to us in this way.
>> No, specifically not, as the values defined there may not correspond
>> with the ones Xen defines (POSIX doesn't mandate specific numbers).
> 
> Good point, which reminds me.
> 
> The Xen error numbers must form part of the public API, as they are
> already part of the public ABI.

Right. But probably something to be dealt with post-4.5.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel