[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

On 11/18/2014 03:10 PM, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 
> for domU"):
>> I need to create an empty structure. Is the dummy field really needed?
> Empty structs are a gcc extension (`(gcc-4.4) Empty Structures').  I
> would be very surprised if clang didn't support them too.

AFAIK, clang doesn't complain about empty structures.

> AIUI our policy, gcc extensions are fine except in the Xen public
> headers.

We have at least 2 "empty" structure on the ARM public header.

>> If so, did you meant?
>> struct
>> {
>>    int :0;
>> }
> Whatever you do, don't do this!

Would something like below be better?

  int dummy:1


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.