Re: [Xen-devel] [PATCH v2 4/4] dt-uart: support /chosen/stdout-path property.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 12/01/15 15:22, Ian Campbell wrote:
> On Thu, 2015-01-08 at 13:30 +0000, Julien Grall wrote:
>> On 08/01/15 13:22, Ian Campbell wrote:
>>> On Thu, 2015-01-08 at 13:15 +0000, Julien Grall wrote:
>>>> Hi Ian,
>>>>
>>>> On 08/01/15 11:53, Ian Campbell wrote:
>>>>> +            ret = dt_property_read_string(chosen, "stdout-path", 
>>>>> &stdout);
>>>>> +            if ( ret >= 0 )
>>>>> +            {
>>>>> +                printk("Taking dtuart configuration from 
>>>>> /chosen/stdout-path\n");
>>>>> +                if ( strlcpy(opt_dtuart, stdout, sizeof(opt_dtuart))
>>>>> +                     >= sizeof(opt_dtuart) )
>>>>> +                    printk("WARNING: /chosen/stdout-path too long, 
>>>>> truncated\n");
>>>>
>>>> I would add XENLOG_WARNING here and ...
>>>>
>>>>> +            }
>>>>> +            else if ( ret != -EINVAL /* Not present */ )
>>>>> +                printk("Failed to read /chosen/stdout-path (%d)\n", ret);
>>>>
>>>> XENLOG_ERROR here.
>>>
>>> In practice these only go via the earlyprintk mechanism, since the
>>> console can't be setup yet. I'm not sure it's worthwhile tagging such
>>> messages.
>>
>> earlyprintk is transparent for the console code. Tagging may help if we
>> decide to implement other kind of console later (VGA, PCI UART...).
>>
>> Anyway, I doesn't change much things here as the message is tagged as
>> WARNING by default. So it will be always printing.
> 
> It turns out that none of the existing prints in this function use the
> tags, and I think its of marginal use in this context so I don't think
> it is necessary to go changing them all, or to only use the tags for
> these two messages.

Ok. I'm fine with it.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel