[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH V3 02/12] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'



>>> On 29.01.15 at 22:46, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS                        2
> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR                        2

While this one looks okay, ...

> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE                 0
> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_DISABLE                1
> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION   2
> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE                 0
> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE                1
> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION   2

... I don't think the _DOMCTL and _OP in these are really necessary
or meaningful. I realize they were this way before, but now that
you touch them anyway...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.