Re: [Xen-devel] [RFC PATCH V3 02/12] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Tue, Feb 3, 2015 at 4:37 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 29.01.15 at 22:46, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS                        2
>> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR                        2
>
> While this one looks okay, ...
>
>> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE                 0
>> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_DISABLE                1
>> -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION   2
>> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE                 0
>> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_DISABLE                1
>> +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR_ENABLE_INTROSPECTION   2
>
> ... I don't think the _DOMCTL and _OP in these are really necessary
> or meaningful. I realize they were this way before, but now that
> you touch them anyway...
>
> Jan

Good idea!

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel