Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 05/02/2015 22:52, Ian Campbell wrote:
> On Thu, 2015-02-05 at 22:29 +0800, Julien Grall wrote:
> > On 05/02/2015 19:42, Ian Campbell wrote:
> > > On Wed, 2015-02-04 at 21:57 +0000, Julien Grall wrote:
> > >
> > > > I believe that most of the SPCR parsing should be generic, so maybe you
> > > > could extend the DEVICE interface to handle the ACPI case.
> > > Extending DT_DEVICE would be confusing IMHO. The answer is probably a
> > > similar but parallel ACPI_DEVICE mechanism, perhaps sharing some
> > > underlying infrastructure with DT_DEVICE.
> > I was thinking to rename DT_DEVICE into something more meaningful.
> > Because infine, DT_DEVICE_START/DT_DEVICE_END doesn't do anything DT
> > specific but defined the a printed name and the device class.
> >
> > So we can extend the device framework without adding too much new code.
> Remember that things like the probe function are going to have different
> prototypes. It also contains things like the DT compat list which is DT
> specific.
>
> So, I think the macros should remain boot firmware specific, whether
> they fill in the same array or not is an implementation detail, but it
> would seem less error prone to split them up.
We may duplicate some fields with this. Although we are talking about 
only few bytes.
So I guess it's fine.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel