Re: [Xen-devel] [PATCH RFC 18/35] arm : add helper function for setting interrupt type

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 05/02/2015 23:33, Stefano Stabellini wrote:
> On Wed, 4 Feb 2015, parth.dixit@xxxxxxxxxx wrote:
> > From: Parth Dixit <parth.dixit@xxxxxxxxxx>
> >
> > set edge/level type information for an interrupt
> >
> > Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
> > ---
> >   xen/arch/arm/irq.c        | 19 +++++++++++++++++++
> >   xen/include/asm-arm/irq.h |  4 ++++
> >   2 files changed, 23 insertions(+)
> >
> > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> > index 25ecf1d..ae4e99a 100644
> > --- a/xen/arch/arm/irq.c
> > +++ b/xen/arch/arm/irq.c
> > @@ -545,6 +545,25 @@ int platform_get_irq(const struct dt_device_node *device, 
> > int index)
> >       return irq;
> >   }
> >
> > +#if defined(CONFIG_ARM_64) && defined(CONFIG_ACPI)
> > +int acpi_set_irq(int irq,int type)
> > +{
> > +    int res;
> > +
> > +    /* Setup the IRQ type */
> > +    if ( irq < NR_LOCAL_IRQS )
> > +        res = irq_local_set_type(irq, type);
> > +    else
> > +        res = irq_set_spi_type(irq, type);
> > +
> > +    if ( res )
> > +        return -1;
> > +
> > +    return 0;
> > +
> > +}
> > +#endif
> As you are using this function in previous patches, you should
> defenitely move this patch earlier in the series.
>
> Please introduce another set of IRQ_TYPEs that are not DT specific, or
> make the existing ones generic.
The existing (DT_IRQ_*) one has to be kept because it's part of the 
device tree bindings.
I would introduce new one and, if necessary, add function to translate 
DT_IRQ_* to IRQ_TYPEs.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel