[Xen-devel] Usage of efi_enabled - Was: Re: [PATCH RFC 33/35] arm : acpi enable efi for acpi

[Julien Grall <julien.grall@xxxxxxxxxx>]

(Adding Roy)

Hi Jan and Roy,

On 04/02/2015 22:02, parth.dixit@xxxxxxxxxx wrote:
> From: Parth Dixit <parth.dixit@xxxxxxxxxx>
>
> efi should be enabled to fetch the root pointer from uefi
>
> Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
> ---
>   xen/common/efi/runtime.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
> index c840e08..c8b8642 100644
> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -11,7 +11,13 @@ DEFINE_XEN_GUEST_HANDLE(CHAR16);
>   #ifndef COMPAT
>
>   #ifdef CONFIG_ARM  /* Disabled until runtime services implemented */
> +
> +#if defined(CONFIG_ARM_64) && defined(CONFIG_ACPI)
> +const bool_t efi_enabled = 1;
> +#else
>   const bool_t efi_enabled = 0;
> +#endif
> +
Thinking a bit more about this variable. The usage of the variable is 
unclear. Does it mean that Xen is supporting EFI runtime or Xen has been 
boot with EFI?
The binary produced on ARM64 always is able to boot with and without 
EFI. So it would seems logical to me that the value of this variable may 
change at runtime.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel