[Xen-devel] Usage of efi_enabled - Was: Re: [PATCH RFC 33/35] arm : acpi enable efi for acpi

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.02.15 at 10:51, <julien.grall@xxxxxxxxxx> wrote:
>> --- a/xen/common/efi/runtime.c
>> +++ b/xen/common/efi/runtime.c
>> @@ -11,7 +11,13 @@ DEFINE_XEN_GUEST_HANDLE(CHAR16);
>>   #ifndef COMPAT
>>
>>   #ifdef CONFIG_ARM  /* Disabled until runtime services implemented */
>> +
>> +#if defined(CONFIG_ARM_64) && defined(CONFIG_ACPI)
>> +const bool_t efi_enabled = 1;
>> +#else
>>   const bool_t efi_enabled = 0;
>> +#endif
>> +
> 
> Thinking a bit more about this variable. The usage of the variable is 
> unclear. Does it mean that Xen is supporting EFI runtime or Xen has been 
> boot with EFI?

The latter (it just so happens that it also means the former on x86
for the time being).

> The binary produced on ARM64 always is able to boot with and without 
> EFI. So it would seems logical to me that the value of this variable may 
> change at runtime.

Correct - other than (currently) on x86.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel