Re: [Xen-devel] [PATCH 3/3] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.02.15 at 13:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 11/02/15 11:02, Jan Beulich wrote:
>>>>> On 10.02.15 at 18:12, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> +     * to construct a writable mapping.
>>> +     */
>>> +    set_fixmap(FIX_TBOOT_MAP_ADDRESS, __pa(&exception_table[TRAP_nmi]));
>>> +    write_atomic((unsigned long *)
>>> +                 (fix_to_virt(FIX_TBOOT_MAP_ADDRESS) +
>>> +                  ((unsigned long)&exception_table[TRAP_nmi] & 
>>> ~PAGE_MASK)),
>>> +                 (unsigned long)&do_nmi_crash);
>> By converting the first cast to (void **) or even
>> (typeof(do_nmi_crash) **) it would seem possible to drop the last
>> cast altogether. While at it you could also drop the unnecessary &.
> 
> None of these casts can be dropped, because write_atomic() uses explicit
> uint??_t casts.  Gcc objects because of -Werror=pointer-to-int-cast.

Oh, indeed (and all that on only the unused cases of the switch).
In that case no need to re-submit, fixing the typos can be done
while committing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel