Re: [Xen-devel] PML (Page Modification Logging) design for Xen

[Tim Deegan <tim@xxxxxxx>]

At 10:19 +0000 on 17 Feb (1424164775), Jan Beulich wrote:
> >>> On 12.02.15 at 03:39, <kai.huang@xxxxxxxxxxxxxxx> wrote:
> > On 02/11/2015 07:52 PM, Andrew Cooper wrote:
> >> On 11/02/15 08:28, Kai Huang wrote:
> >>> Currently, PML will be used as long as there's guest memory in dirty
> >>> logging mode, no matter globally or partially. And in case of partial
> >>> dirty logging, we need to check if the logged GPA in PML buffer is in
> >>> dirty logging range.
> >> I am not sure this is a problem.  HAP vram tracking already leaks
> >> non-vram frames into the dirty bitmap, caused by calls to
> >> paging_mark_dirty() from paths which are not caused by a p2m_logdirty 
> >> fault.
> > Hmm. Seems right. Probably this also depends on how userspace uses the 
> > dirty bitmap.
> > 
> > If this is not a problem, we can avoid the checking of whether logged 
> > GPAs are in logdirty ranges but unconditionally update them to log-dirty 
> > radix tree.
> > 
> > Jan, what's your comments here?
> 
> I agree with Andrew, but Tim's confirmation would be nice to have.

Yes, I agree (as I said in an earlier reply, but understood that this
is a rambling thread).

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel