Re: [Xen-devel] [PATCH v18 11/16] x86/VPMU: Handle PMU interrupts for PV guests

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/02/15 22:26, Boris Ostrovsky wrote:
> diff --git a/xen/arch/x86/hvm/vpmu.c b/xen/arch/x86/hvm/vpmu.c
> index 1d5ae8d..cf4c70b 100644
> --- a/xen/arch/x86/hvm/vpmu.c
> +++ b/xen/arch/x86/hvm/vpmu.c
>
> +static struct vcpu *choose_hwdom_vcpu(void)
> +{
> +    unsigned idx = smp_processor_id() % hardware_domain->max_vcpus;
> +
> +    if ( hardware_domain->vcpu == NULL )
> +        return NULL;

If d->vcpu is NULL, d->max_vcpus was 0 and you have already died with a #DE

You can guarentee that if max_vcpus > 0, d->vcpu is not NULL.

~Andrew

> +
> +    return hardware_domain->vcpu[idx];
> +}
> +




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel