Re: [Xen-devel] [PATCH v9 02/13] xen: Add support for VMware cpuid leaves

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.02.15 at 11:02, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 16/02/15 23:05, Don Slutz wrote:
>> --- a/xen/include/asm-x86/hvm/hvm.h
>> +++ b/xen/include/asm-x86/hvm/hvm.h
>> @@ -356,6 +356,13 @@ static inline unsigned long 
>> hvm_get_shadow_gs_base(struct vcpu *v)
>>  #define has_viridian_time_ref_count(d) \
>>      (is_viridian_domain(d) && (viridian_feature_mask(d) & 
>> HVMPV_time_ref_count))
>>  
>> +#define vmware_feature_mask(d) \
>> +    (has_hvm_params(d) ? \
>> +     (d)->arch.hvm_domain.params[HVM_PARAM_VMWARE_HWVER] : 0)
> 
> I can't spot any use of this vmware_feature_mask().  Is it stale?

No, it is being used ...

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
>> +
>> +#define is_vmware_domain(d) \
>> +    (is_hvm_domain(d) && vmware_feature_mask(d))

... here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel