Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.03.15 at 11:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 02/03/15 10:46, Jan Beulich wrote:
>>>>> On 02.03.15 at 11:15, <olaf@xxxxxxxxx> wrote:
>>> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation.
>>> Remove incorrect reference to WWN because it was never supported. And
>>> its not clear how it could be supported. p-devname can be used to store
>>> a config string.
>> I'm not sure - even if a particular implementation doesn't support
>> certain functionality, I would say the interface definition can still
>> name this as a possibility.
> 
> It would be misleading to suggest it is available if it is not
> implemented.  Furthermore, Olaf's comment suggests that it cant be
> supported with this key, at which point the reference should absolutely
> be removed.

"It's not clear" != "can't" (at least in my understanding of the words).
And no, as said I don't think the interface description should be in any
way tailored towards a specific implementation. As that aspect is a
host local thing only anyway, amending the text to say "in host
specific ways" or "as supported by the particular backend
implementation" or some such may be desirable.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel