Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/03/15 10:55, Jürgen Groß wrote:
> On 03/02/2015 11:50 AM, Andrew Cooper wrote:
>> On 02/03/15 10:46, Jan Beulich wrote:
>>>>>> On 02.03.15 at 11:15, <olaf@xxxxxxxxx> wrote:
>>>> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l
>>>> notation.
>>>> Remove incorrect reference to WWN because it was never supported. And
>>>> its not clear how it could be supported. p-devname can be used to
>>>> store
>>>> a config string.
>>> I'm not sure - even if a particular implementation doesn't support
>>> certain functionality, I would say the interface definition can still
>>> name this as a possibility.
>>
>> It would be misleading to suggest it is available if it is not
>> implemented.  Furthermore, Olaf's comment suggests that it cant be
>> supported with this key, at which point the reference should absolutely
>> be removed.
>
> The pvops backend supports this variant.

In which case it really should stay.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel