Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 11/03/2015 14:03, Jan Beulich wrote:
> > > > On 11.03.15 at 14:55, <ian.campbell@xxxxxxxxxx> wrote:
> > On Wed, 2015-03-11 at 13:50 +0000, Julien Grall wrote:
> > > Hmmm I think I got you point now. Do you mean have something like:
> > That's one option I'd be happy with, yes. Jan might disagree.
> Looks quite reasonable to except for ...
>
> > > switch (domctl->u.assign_device.dev)
> > > {
> > > #ifdef HAS_PCI
> > > case XEN_DOMCTL_DEV_PCI:
> > >       ret = iommu_do_pci_domctl();
> > >       break;
> > > #endif
> > > #ifdef HAS_DEVICE_TREE
> > > case XEN_DOMCTL_DEV_DT:
> > >       ret = iommu_do_dt_domctl()
> > >       break;
> > > #endif
> > >
> > > default:
> > >      ret = -ENOSYS;
> ... the -ENOSYS here: We commonly use e.g. -EOPNOTSUPP in
> such situations.
Ok I will use it.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel