[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags



>>> On 19.03.15 at 14:12, <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
> Am Dienstag 17 MÃrz 2015, 10:54:02 schrieb Boris Ostrovsky:
>> +    case XENPMU_feature_get:
> 
> memset(&pmu_params, 0, sizeof(pmu_params));  ?
> 
>> +        pmu_params.val = vpmu_features;
>> +        if ( copy_field_to_guest(arg, &pmu_params, val) )
>> +            return -EFAULT;

Why? Notice the _field_ in the used function's name.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.