[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
- Date: Thu, 19 Mar 2015 14:49:49 +0100
- Cc: kevin.tian@xxxxxxxxx, suravee.suthikulpanit@xxxxxxx, andrew.cooper3@xxxxxxxxxx, tim@xxxxxxx, xen-devel@xxxxxxxxxxxxx, Aravind.Gopalakrishnan@xxxxxxx, jun.nakajima@xxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, dgdegra@xxxxxxxxxxxxx
- Delivery-date: Thu, 19 Mar 2015 13:50:08 +0000
- Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:From:To:Cc:Subject:Date:Message-ID: User-Agent:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:Content-Type; b=A1hhRpbUldLBupqBVVqi/+OskZMLuwE5BEo4JuQslax5g9AKYUKMf8mJ pUC2TxevJ4vN86qxqGULFHDcSVqelZt7CVJ/ps1yX4CHZ8R6ig3w/GngD GwSuMwLqerijd0FlctslfPZZcnyc/UHl83zkAbqrOtk333One7mxohh9i vBqHn6PrQqQGqOdW3Qug6o1pKgcNQxNdaCSHgIRdVvM5qRplPf2Ig89Tl 1FzQSVSKzJe5a+EUxXN5CFPZ90GmW;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Am Donnerstag 19 MÃrz 2015, 13:28:56 schrieb Jan Beulich:
> >>> On 19.03.15 at 14:12, <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
> > Am Dienstag 17 MÃrz 2015, 10:54:02 schrieb Boris Ostrovsky:
> >> + case XENPMU_feature_get:
> >
> > memset(&pmu_params, 0, sizeof(pmu_params)); ?
> >
> >> + pmu_params.val = vpmu_features;
> >> + if ( copy_field_to_guest(arg, &pmu_params, val) )
> >> + return -EFAULT;
>
> Why? Notice the _field_ in the used function's name.
>
> Jan
Ah, yes, thanks! Sorry for noise.
Dietmar.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|