[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH v2 00/22] xen/arm: Add ITS support

Hi Vijay,

On 19/03/2015 14:37, vijay.kilari@xxxxxxxxx wrote:
From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Add ITS support for arm. Following major features
are supported
  - GICv3 ITS support for arm64 platform
  - Supports multi ITS node
  - LPI descriptors are allocated on-demand
  - Only ITS Dom0 is supported

Tested with single ITS node.

Some though about the whole design:

Your vGIC ITS driver does too much things. In general a virtual driver should only emulate the hardware for the domain and forward the request to the physical driver.

Your series adds device management (create/free) in the vITS, which is wrong.

How do you check if the domain can use the device?
Currently, you allow any domain to use any device. That would bring a big mess with guest using passthrough.

Also, does the guess will always pass the correct devid? If not how do you plan to handle it?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.