Re: [Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote:
> The libxl__spawn_spawn internal API permits the caller to specify
> .timeout_ms==-1, meaning to wait forever.  Provide an explicit
> cancellable to allow spawns to be cancelled.

AIUI this also lets spawns with timeout_ms > -1 to be cancelled, which I
think is desirable.

> I think there are not currently any internal callers which do use
> spawn with an infinite timeout, but this should not be left as a
> lacuna for later.
> 
> Also, this change means that in practice anything which is cancelled
> while spawning ought to be queued for two cancellation notifications:
> one from its timeout, and one from the explicit cancellation
> registration.  Hopefully this will mean that more exciting paths are
> exercised during testing.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel