[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable
Ian Campbell writes ("Re: [Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable"): > On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote: > > The libxl__spawn_spawn internal API permits the caller to specify > > .timeout_ms==-1, meaning to wait forever. Provide an explicit > > cancellable to allow spawns to be cancelled. > > AIUI this also lets spawns with timeout_ms > -1 to be cancelled, which I > think is desirable. Yes. Spawns with finite timeouts will be cancelled either by the explicit cancellable in the spawn, or the one implied by the finite timeout; it doesn't matter which - the path goes from spawn_cancel or spawn_watch_event (respectively) to spawn_fail. I was going to say that this patch is needed because libxl__ev_time's cancellable is not registered when the timeout is infinite. But actually I see from libxl_event.c that this isn't the case. So I think I should drop this patch. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |