Re: [Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

[Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>]

On Wed, Mar 25, 2015 at 10:08:20AM +0000, Jan Beulich wrote:
> >>> On 24.03.15 at 19:54, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > On Tue, Mar 24, 2015 at 04:19:24PM +0000, Jan Beulich wrote:
> >> >>> On 24.03.15 at 17:08, <elena.ufimtseva@xxxxxxxxxx> wrote:
> >> > Changes in v2:                                                           
> >> >    
> >  
> >> >    
> >> >  - move rmrr parser to dmar.c and make it custom_param;                  
> >> >     
> >  
> >> >   
> >> >  - change of rmrr command line oprion format; since adding multiple 
> >> > device
> >> >  per range support needs to utilize more special characters and offered 
> > from
> >> >  the previous review ';' is not supported, '[' ']' are reserved, ':' and 
> >> > used in pci
> >> >  format, range and devices are separated by '#'; Suggestions are 
> >> > welcome;  
> >> 
> >> What is it that makes ';' not supported?
> > 
> > Grub interprets the string after ; as an environment variable,
> > so I get this with version 2.02~beta2-15:
> > 
> > This is when there is ';' before second range 0xd5d45-0xd5d46.
> > 
> >   Booting a command list
> > 
> >   error: invalid variable name `0xd5d45-0xd5d46'.
> 
> To be honest I'm not sure we want to work around grub bugs (or
> should I call it features) like this. Grub should be fixed instead. At
> the very least ';' should remain the primary separator here, and a
> secondary one might be supported to work around this grub quirk.
> Apart from that - is there anything else that's broken, or is the
> presence of the error message just a cosmetic issue?
>
Hi Jan                                                                          
Looks like ';' is a valid syntax reserved character for grub, see
section       
5.2:                                                                            
http://www.gnu.org/software/grub/manual/grub.html                               
Along the messages, the part of the string after ';' is ignored.                
Does not look its a bug, but rather a feature.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel