Re: [Xen-devel] [PATCH v4 09/33] xen: Extend DOMCTL createdomain to support arch configuration

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-03-19 at 19:29 +0000, Julien Grall wrote:
> On ARM the virtual GIC may differ between each guest (emulated GIC version,
> number of SPIs...). This information is already known at the domain creation
> and can never change.
> 
> For now only the gic_version is set. In the long run, there will be more
> parameters such as the number of SPIs. All will be required to be set at the
> same time.
> 
> A new arch-specific structure arch_domainconfig has been created, the x86
> one doesn't have any specific configuration, for now, a dummy structure
> (C-spec compliant) has been created.
> 
> Some external tools (qemu, xenstore) may be required to create a domain.
> Rather than asking them to take care of the arch-specific domain
> configuration, let the current function (xc_domain_create) chose a
> default configuration and introduce a new one (xc_domain_create_config).
> 
> This patch also drops the previously introduced DOMCTL arm_configure_domain
> in Xen 4.5, as it has been made useless.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

A couple of minor nits which I'll try and remember to fix on commit if a
resend of the series isn't needed for another reason.

> -    LOG(DEBUG, "  - vGIC version: %s", gicv_to_string(config.gic_version));
> +    LOG(DEBUG, " - vGIC version: %s\n", 
> gicv_to_string(xc_config->gic_version));

Log adds the \n itself. 
>      /* Create initial domain 0. */
> -    dom0 = domain_create(0, 0, 0);
> +    /* The vGIC for DOM0 is exactly emulated the hardware GIC */

"emulating"

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel