Re: [Xen-devel] [PATCH 10/29] libxl: events: Make timeout and async exec setup take an ao, not a gc

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wen Congyang writes ("Re: [PATCH 10/29] libxl: events: Make timeout and async 
exec setup take an ao, not a gc"):
> On 02/11/2015 04:09 AM, Ian Jackson wrote:
> > Change the timeout setup functions to take a libxl__ao, not a
> > libxl__gc.  This is going to be needed for ao cancellation, because
> > timeouts are going to be a main hook for ao cancellation - so the
> > timeouts need to be associated with an ao.
> > 
> > This means that timeouts can only occur as part of a long-running
> > libxl function (but this is of course correct, as libxl shouldn't have
> > any global timeouts, and indeed all the call sites have an ao).
> > 
> > Also remove the gc parameter from libxl__async_exec_start.  It can
> > just use the gc from the ao supplied in the aes.

> > Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > CC: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> > CC: Wen Congyang <wency@xxxxxxxxxxxxxx>
> > CC: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> 
> libxl__async_exec_start() related modifications look fine to me.

Thanks for the review.  I'll take that as ack, if you don't object.

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel