Re: [Xen-devel] [PATCH 16/29] libxl: ao: Provide manip_refcnt

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 16/29] libxl: ao: Provide 
manip_refcnt"):
> On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote:
> > +/*
> > + * A "manip" is a libxl public function manipulating this ao, which
> > + * has a pointer to it.  We have to not destroy it while that's the
> > + * case, obviously.
> 
> It might be nice to the reader to make a reference to the "An ao and its
> gc may be accessed only with the ctx lock held." sentence in the overall
> ao docs?

This seems to have been documented already in May 2012 in exactly
those terms, at the top of struct libxl__ao, in 738b3d442522.  Am I
confused ?

I have added a comment about locking in the manip functions' doc
comment.

> [...]
> > +        libxl__ao__destroy(ctx,ao);
> 
> Nit: missing space after ",".

Fixed.

> But other than those and including if you disagree about extending the
> comment, since it's not a big deal:
>         Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel