Re: [Xen-devel] [PATCH V14 2/7] xen/arm: Implement domain_get_maximum_gpfn

[Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>]

On Wed, Apr 8, 2015 at 3:42 PM, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:

On 08/04/15 14:38, Tamas K Lengyel wrote:
> The patch that will use xc_domain_maximum_gpfn is not included right now
> in this series as my other series significantly cleans up the existing
> xen-access test code. Before that's merged, there is no point in
> carrying that patch here as it will be in conflict anyway. I'm intending
> to send that once my cleanup series is merged (or append it to this
> series again if it's still open).

I was going to say that xen-access is not modified to support ARM. But I
guess the xc_domain_maximum_gpfn will be used in order to fix it?

Although, this hypercall is really buggy for ARM platform. It would be
better to pass to add a parameter in order to get the maximum pfn rather
than using the return value which will be truncated in many different
ways later.

Regards,

--
Julien Grall

I think updating libxc to not truncate the value would be the preferred way to go forward (changing return type to uint64_t). I already added those changes to this patch and it's only a handful of instances.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel