Re: [Xen-devel] [PATCH 3/3] xen/iommu: disable IOMMU engine completely before enter S5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.15 at 04:16, <tiejun.chen@xxxxxxxxx> wrote:
> S5 menas we also shut down IOMMU engine as well, so we should
> disable IOMMU engine completely before enter S5, otherwise we
> still probably receive some interrupts in this period. But
> currently VT-D path depends on force_iommu and iommu_intremap
> to determine if we should disable translation and queued
> invalidation. So this unexpected behaviour can be fixed by
> clearing force_iommu and iommu_intremap.

Maybe it can, but is this the right way to do it? Fiddling with IOMMU
internal variables in xen/arch/x86/acpi/power.c seems bogus (not
to say hacky) at least. And why would this be S5-specific?

> Additionally, some cleanups to code comments.

Which has nothing to do in tis patch.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel