Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-05-05 at 18:47 +0100, Stefano Stabellini wrote:
> > I was suggesting ts-raisin-build could contain just 1. a call to raise
> > to list all the relevant trees 2. an iteration over the output,
> > copying information to/from runvars, 3. an exception table to allow
> > for situations like 'QEMU' ne uc 'qemuu' and 'QEMU_TRADITIONAL' ne uc
> > 'qemuu'.
> 
> raisin does not have a list of trees, if not in the form of a default
> config file provided for users' convenience. Theoretically
> ts-raisin-build could use the default config and grep _URL
> raisin/defconfig, but I think it would be uglier than the current
> approach.
> 
> Keep in mind that with raisin there is no hidden git cloning of external
> trees. Not at all. All the trees are specified in the config file and
> cloned explicitly. Actually I think that it is nice and natural for
> ts-raisin-build to specify a list of URLs, because ts-raisin-build also
> wants to specify which components raisin is supposed to build and there
> is a 1:1 relationship.

I think a simple mapping from "osstest tree names" to "raisin
components", (or vice versa, but the rest of the mail assumes the
former) ought to be all which is needed here.

Essentially you want to iterate over the runvars looks for things which
match tree_(.*) then (modulo proper Perl syntax):

        my $tree = $1;
     my $comp = $osstest2raisin{$tree}
        push @components, $comp;
        
        echo >> config "uc($comp)_URL=$r{tree_${tree}}"
        echo >> config "uc($comp)_REVISION=$r{revision_${tree}}"

Finally
        my $comps = join(", ", @components);
        
        echo >> config "COMPONENTS=$comps"

I'm assuming that in raisin the component name is consistently also the
first part of the _URL and _REVISION config options, if not then %
osstest2raisin would need to be a hash exploding to the various required
names.

If %osstest2raisin doesn't contain a mapping then that would be an error
I suppose, or you could add "// $tree" to the lookup to default to the
same name.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel