Re: [Xen-devel] [OSSTEST Nested PATCH v9 9/9] Add test job for nest test case

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sat, 2015-05-02 at 14:28 +0800, longtao.pang wrote:
> diff --git a/make-flight b/make-flight
> index cc8ecdb..b5c7c27 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -204,6 +204,37 @@ do_hvm_win7_x64_tests () {
>              all_hostflags=$most_hostflags,hvm
>  }
>  
> +do_hvm_debian_nested_tests () {
> +  if [ $xenarch != amd64 -o $dom0arch != amd64 \
> +      -o "x$qemuu_suffix" != "x-qemuu" ]; then
> +    return
> +  fi
> +
> +  case $xenbranch in
> +    xen-3.*-testing)      return;;
> +    xen-4.0-testing)      return;;
> +    xen-4.1-testing)      return;;
> +    xen-4.2-testing)      return;;
> +    xen-4.3-testing)      return;;
> +  esac
> +  # Define bios type, in 'ts-debian-hvm-install' script will use it,
> +  # or will die if "$r{bios}" undefined.
> +  bios=$1

Please can you just put
        bios=$1
as the first line in the function, followed by a blank line, followed by
the $xenarch/$domarch/$qemuu_suffix test. No need for the comment.

> +
> +  job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-nested \
> +            test-nested xl $xenarch $dom0arch $qemuu_runvar \
> +            nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl1_vifmodel='e1000' \
> +            nestedl1_disksize='15000' \
> +            nestedl1_memsize='3072' \
> +            nestedl1_enable_nestedhvm='true' \
> +            nestedl1_guest_storage_size='20000' \
> +            nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl2_disksize='15000' \
> +            bios=$bios
> +            all_hostflags=$most_hostflags,hvm

Looks good, thanks.

With the bios= moved:
        Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel