Re: [Xen-devel] [PATCH v2 1/8] xenalyze: add to tools/xentrace/xenalyze

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, May 7, 2015 at 11:35 AM, Olaf Hering <olaf@xxxxxxxxx> wrote:
> This merges xenalyze.hg, changeset 150:24308507be1d into
> tools/xentrace/xenalyze to have the tool and public/trace.h in one
> place.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  .gitignore                         |     1 +
>  tools/xentrace/Makefile            |     4 +
>  tools/xentrace/xenalyze/Makefile   |    21 +
>  tools/xentrace/xenalyze/analyze.h  |   107 +
>  tools/xentrace/xenalyze/mread.c    |   160 +
>  tools/xentrace/xenalyze/mread.h    |    18 +
>  tools/xentrace/xenalyze/pv.h       |    41 +
>  tools/xentrace/xenalyze/xenalyze.c | 10407 
> +++++++++++++++++++++++++++++++++++
>  8 files changed, 10759 insertions(+)

Hmm, I had thought you were going to plop the files all in
tools/xentrace, rather than making another subdirectory.  (Sorry for
not looking more closely yesterday.)

I personally think it would make more sense to just put the xenalyze
directory in tools/.

Wei / Ian / Ian, any opinions here?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel