[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 7/8] xenalyze: remove traling whitespaces

On 05/07/2015 06:26 PM, Andrew Cooper wrote:
> On 07/05/15 11:35, Olaf Hering wrote:
>> Result of "sed -i 's@[[:blank:]]\+$@@' tools/xentrace/xenalyze/xenalyze.c"
>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Why not refresh patch 1 using git's --whitespace=fix mode?  It would
> save adding whitespace just to remove it again, and also fix up the
> other imported files.

Presumably he was trying to be diligent about making sure he checked in
exactly what was in the repo?

I'm fine with Andrew's suggestion, FWIW.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.