Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, May 07, 2015 at 10:35:42AM +0000, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/xentrace/xenalyze/xenalyze.c | 73 
> ++++++++++++++++++++++++++++++++++----
>  1 file changed, 66 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/xentrace/xenalyze/xenalyze.c 
> b/tools/xentrace/xenalyze/xenalyze.c
> index 0566d00..18ca859 100644
> --- a/tools/xentrace/xenalyze/xenalyze.c
> +++ b/tools/xentrace/xenalyze/xenalyze.c
> @@ -30,6 +30,7 @@
>  #include <fcntl.h>
>  #include <unistd.h>
>  #include <public/trace.h>
> +#include <public/sched.h>
>  #include "analyze.h"
>  #include "mread.h"
>  #include "pv.h"
> @@ -7569,24 +7570,82 @@ void sched_summary_domain(struct domain_data *d)
>      }
>  }
>  
> +void sched_class(struct record_info *ri)
> +{
> +}

Huh, this does nothing? Is it because this is only a stub (you haven't
got around to implement it) or it is supposed to be like this?

Either case could you please add a comment before this function? Thanks.

>  
>  void sched_process(struct pcpu_info *p)
>  {
>      struct record_info *ri = &p->ri;
>  
> -    if(ri->evt.sub == 0xf) {
> +    if (ri->evt.sub == 1) {
> +        sched_runstate_process(p);
> +    } else if (ri->evt.sub == 2) {
> +        sched_class(ri);
> +    } else {
>          switch(ri->event)
>          {

[...]

> +            break;
>          default:
> -            process_generic(&p->ri);
> -        }
> -    } else {
> -        if(ri->evt.sub == 1)
> -            sched_runstate_process(p);
> -        else {
> +            fprintf(warn, "%s: event:%x (min:%x sub:%x main:%x)\n", 
> __func__, ri->event, ri->evt.minor, ri->evt.sub, ri->evt.main);

This line is really too long, please wrap it. And this won't look broken
when you wrap it.

Wei.

>              UPDATE_VOLUME(p, sched_verbose, ri->size);
>              process_generic(&p->ri);
>          }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel