Re: [Xen-devel] [xen-unstable test] 53884: regressions - FAIL

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.05.15 at 10:19, <JBeulich@xxxxxxxx> wrote:
>>>> On 11.05.15 at 10:12, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 11/05/2015 09:08, Jan Beulich wrote:
>>>>>> On 09.05.15 at 20:57, <osstest@xxxxxxxxxxxxxxx> wrote:
>>>> flight 53884 xen-unstable real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/53884/ 
>>>>
>>>> Regressions :-(
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>  build-amd64-xsm               5 xen-build                 fail REGR. vs. 
>>>> 50405
>>> This is due to e5786bae04 ("x86/pvh: use a custom IO bitmap for
>>> PVH hardware domains"). Having requested th addition during
>>> review I of course took it for granted that you build tested your
>>> change. As dealing with this imo also means moving the code
>>> addition into the already existing (or a new) CONFIG_X86 block
>>> (along with moving the declaration to a more suitable header), I
>>> think a fixup patch would not be the right way to deal with this,
>>> and hence I think I'm going to revert that change for the time
>>> being.
>> 
>> Given this reversion (and confirmation that the build is fixed), would a
>> force push be justified?  We are now a full month behind, with other 
>> OSSTest issues still outstanding.
> 
> While it'd be really nice to do so, the flight here didn't test the tip of
> staging (onto which I'll push the revert in a few minutes), so a force
> push may be a little difficult to arrange. I'm also afraid that doing so
> would yield the XSM build failure an allowable one going forward.
> Otoh, considering that we got two almost-pushes recently, I'm quite
> hopeful that we'll get a real push pretty soon.

And sadly 6ea9f0481e ("xen: guestcopy: Provide an helper to
safely copy string from guest") breaks the x86 XSM build too (due
to type issues with the compat mode layer of flask's hypercall
handling). Reverting that one would be more cumbersome (as I
suppose subsequent changes depend on it), but I very much
hope that you, Julien, will provide a timely fix for this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel