Re: [Xen-devel] [OSSTEST v6 01/24] TestSupport: Add helper to fetch a URL on a host

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[OSSTEST v6 01/24] TestSupport: Add helper to fetch a URL 
on a host"):
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> +sub target_fetchurl($$$;$) {
> +    my ($ho, $url, $path, $timeo) = @_;
> +    $timeo ||= 2000;
> +    my $useproxy = "export http_proxy=$c{HttpProxy};" if $c{HttpProxy};
> +    target_cmd_root($ho, "$useproxy wget --progress=dot:mega -O $path $url", 
> $timeo);

Do we care that this will break badly if the url contains shell
metacharacters ?  I think we may do.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel