Re: [Xen-devel] [OSSTEST v6 01/24] TestSupport: Add helper to fetch a URL on a host

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-05-12 at 16:08 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 01/24] TestSupport: Add helper to fetch a 
> URL on a host"):
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> > +sub target_fetchurl($$$;$) {
> > +    my ($ho, $url, $path, $timeo) = @_;
> > +    $timeo ||= 2000;
> > +    my $useproxy = "export http_proxy=$c{HttpProxy};" if $c{HttpProxy};
> > +    target_cmd_root($ho, "$useproxy wget --progress=dot:mega -O $path 
> > $url", $timeo);
> 
> Do we care that this will break badly if the url contains shell
> metacharacters ?  I think we may do.

I agree.

Is adding \" around the $url is all which is needed there, or are there
enough layers of quoting that it is more complicated than that?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel