Re: [Xen-devel] [PATCH v5 02/14] libxc/save: Adjust stream-position callbacks for checkpointed streams

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-05-14 at 09:52 +0800, Yang Hongyang wrote:
> 
> On 05/13/2015 11:56 PM, Ian Campbell wrote:
> > On Wed, 2015-05-13 at 16:47 +0100, Andrew Cooper wrote:
> >> On 13/05/15 16:46, Ian Campbell wrote:
> >>> On Wed, 2015-05-13 at 09:53 +0800, Yang Hongyang wrote:
> >>>> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >>>>
> >>>> There are some records which should only be sent once in the stream, and 
> >>>> not
> >>>> repeated for each checkpoint.  {start,end}_of_stream() become 
> >>>> per-checkpoint,
> >>>> and a new start_of_stream() is introduced.
> >>>>
> >>>> There is no resulting change record order, but the X86_PV_INFO record is
> >>>> identified as once per stream.  Currently the X86_PV_P2M_FRAMES record 
> >>>> is as
> >>>> well, but this is because of an implementation bug and can move back to 
> >>>> being
> >>>> on an as-needed basis when fixed.
> >>>>
> >>>> In addition, a few minor adjustments of comments and layout.
> >>>>
> >>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >>> Subject to my finding a suitable documentation update further down the
> >>> series:
> >>>
> >>> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> >>
> >> What update are you expecting?  X86_PV_INFO is already strictly defined
> >> as "sent once" in the spec.
> >
> > Something defining a checkpointed stread.
> 
> I think this is done in the 3rd patch? Can I take this ack?

Yes, thanks.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel