Re: [Xen-devel] [RFC][PATCH 09/13] xen: enable XENMEM_set_memory_map in hvm

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.15 at 08:24, <tiejun.chen@xxxxxxxxx> wrote:
> On 2015/5/15 14:12, Jan Beulich wrote:
>>>>> On 15.05.15 at 04:33, <tiejun.chen@xxxxxxxxx> wrote:
>>> On 2015/4/20 21:46, Jan Beulich wrote:
>>>>>>> On 10.04.15 at 11:22, <tiejun.chen@xxxxxxxxx> wrote:
>>>>> --- a/xen/arch/x86/hvm/hvm.c
>>>>> +++ b/xen/arch/x86/hvm/hvm.c
>>>>> @@ -4729,7 +4729,6 @@ static long hvm_memory_op(int cmd,
>>> XEN_GUEST_HANDLE_PARAM(void) arg)
>>>>>
>>>>>        switch ( cmd & MEMOP_CMD_MASK )
>>>>>        {
>>>>> -    case XENMEM_memory_map:
>>>>
>>>> Title and description talk about XENMEM_set_memory_map only. As
>>>> I think the implementation is right, the former will need updating. Do
>>>> you actually need a HVM domain to be able to XENMEM_set_memory_map
>>>
>>> Yes. Actually we need to enable two hypercalls here,
>>>
>>> #1. XENMEM_set_memory_map --> Set
>>> #2. XENMEM_memory_map --> Get
>>
>> You say "yes" without saying why, and ...
> 
> Instead of constructing e820 in the case of hvmloader, now we'd like to 
> set up a basic e820 while building hvm, so we need to enable 
> XENMEM_set_memory_map/XENMEM_memory_map to own this approach in hvm case.

You continue to ignore ...

>>>> on itself? If not, it should probably replace XENMEM_memory_map here.

... the "on itself" here. Of course the tool stack needs to be able to
invoke this. But does the guest itself need to?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel