Re: [Xen-devel] [PATCH v6 1/2] xen/pvh: use a custom IO bitmap for PVH hardware domains

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.05.15 at 17:27, <roger.pau@xxxxxxxxxx> wrote:
> El 13/05/15 a les 11.53, Jan Beulich ha escrit:
>>>>> On 11.05.15 at 16:57, <roger.pau@xxxxxxxxxx> wrote:
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -42,6 +42,7 @@
>>>  #include <xsm/xsm.h>
>>>  #include <xen/trace.h>
>>>  #include <xen/tmem.h>
>>> +#include <asm/setup.h>
>>>  
>>>  /* Linux config option: propageted to domain0 */
>>>  /* xen_processor_pmbits: xen control Cx, Px, ... */
>>> @@ -219,6 +220,7 @@ static int late_hwdom_init(struct domain *d)
>>>      rangeset_swap(d->iomem_caps, dom0->iomem_caps);
>>>  #ifdef CONFIG_X86
>>>      rangeset_swap(d->arch.ioport_caps, dom0->arch.ioport_caps);
>>> +    setup_io_bitmap(d);
>>>  #endif
>> 
>> Considering that rangesets are getting swapped rather than
>> copied, I think you also need to reset Dom0's I/O bitmap here
>> to the ordinary, non-hardware domain one.
> 
> Yes. Would it be fine to memset it and just call setup_io_bitmap on it
> again, or would you prefer to exchange it with the static one and free it?

Following how the rangesets are being treated, simply swapping
the two I/O bitmaps would seem to be the right approach here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel