Re: [Xen-devel] [PATCH v2 20/41] arm : create generic uart initialization function

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
> --- a/xen/drivers/char/Makefile
> +++ b/xen/drivers/char/Makefile
> @@ -6,5 +6,5 @@ obj-$(HAS_EXYNOS4210) += exynos4210-uart.o
>  obj-$(HAS_OMAP) += omap-uart.o
>  obj-$(HAS_SCIF) += scif-uart.o
>  obj-$(HAS_EHCI) += ehci-dbgp.o
> -obj-$(CONFIG_ARM) += dt-uart.o
> +obj-$(CONFIG_ARM) += arm-uart.o

The patch is missing the corresponding source file.

Also. uart_init() being (presumably) implemented in that file is in
no way "generic" - it's still ARM specific, and hence it should be
named that way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel